netdev - Re: [iwl-next v1 0/4] ice: prepare representor for SF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiZf0k-38srn486H@nanopsycho>
Date: Mon, 22 Apr 2024 15:02:10 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	jacob.e.keller@...el.com, michal.kubiak@...el.com,
	maciej.fijalkowski@...el.com, sridhar.samudrala@...el.com,
	przemyslaw.kitszel@...el.com, wojciech.drewek@...el.com,
	pio.raczynski@...il.com, jiri@...dia.com,
	mateusz.polchlopek@...el.com, shayd@...dia.com
Subject: Re: [iwl-next v1 0/4] ice: prepare representor for SF support

Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkowski@...ux.intel.com wrote:
>Hi,
>
>This is a series to prepare port representor for supporting also
>subfunctions. We need correct devlink locking and the possibility to
>update parent VSI after port representor is created.
>
>Refactor how devlink lock is taken to suite the subfunction use case.
>
>VSI configuration needs to be done after port representor is created.
>Port representor needs only allocated VSI. It doesn't need to be
>configured before.
>
>VSI needs to be reconfigured when update function is called.
>
>The code for this patchset was split from (too big) patchset [1].
>
>[1] https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkowski@linux.intel.com/
>
>Michal Swiatkowski (4):
>  ice: store representor ID in bridge port
>  ice: move devlink locking outside the port creation
>  ice: move VSI configuration outside repr setup
>  ice: update representor when VSI is ready

FWIW, looks fine to me.


>
> .../net/ethernet/intel/ice/devlink/devlink.c  |  2 -
> .../ethernet/intel/ice/devlink/devlink_port.c |  4 +-
> drivers/net/ethernet/intel/ice/ice_eswitch.c  | 83 +++++++++++++------
> drivers/net/ethernet/intel/ice/ice_eswitch.h  | 14 +++-
> .../net/ethernet/intel/ice/ice_eswitch_br.c   |  4 +-
> .../net/ethernet/intel/ice/ice_eswitch_br.h   |  1 +
> drivers/net/ethernet/intel/ice/ice_repr.c     | 16 ++--
> drivers/net/ethernet/intel/ice/ice_repr.h     |  1 +
> drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  2 +-
> 9 files changed, 88 insertions(+), 39 deletions(-)
>
>-- 
>2.42.0
>
>