netdev - Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240422064825.18850cc3@kernel.org>
Date: Mon, 22 Apr 2024 06:48:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Ahern <dsahern@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net,
 netdev@...r.kernel.org, pabeni@...hat.com, shuah@...nel.org,
 sdf@...gle.com, amritha.nambiar@...el.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in
 qstats

On Sun, 21 Apr 2024 13:32:24 -0600 David Ahern wrote:
> On 4/21/24 1:17 PM, Eric Dumazet wrote:
> > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ?  
> 
> good point. We do set that flag for other dumps when a filter has been
> used to limit data returned.

That flag appears to be a, hm, historic workaround?
If I was to guess what the motivation was I'd say that it's because
"old school netlink" didn't reject unknown attributes. And you wanted
to know whether the kernel did the filtering or you have to filter
again in user space? Am I close? :)

The flag is mostly used in the IP stack, I'd rather try to deprecate 
it than propagate it to new genetlink families which do full input
validation, rendering the flag 100% unnecessary.