netdev - Re: [PATCH net] xfrm: Preserve vlan tags for transport mode software GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZiaMH0e0NL+/P0Fg@gauss3.secunet.de>
Date: Mon, 22 Apr 2024 18:11:11 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: Paul Davey <paul.davey@...iedtelesis.co.nz>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net] xfrm: Preserve vlan tags for transport mode software
 GRO

On Mon, Apr 22, 2024 at 02:49:44PM +0200, Sabrina Dubroca wrote:
> 
> Actually it looks like we still have 4B in xfrm_mode_skb_cb:
> 
> struct xfrm_mode_skb_cb {
> 	struct xfrm_tunnel_skb_cb  header;               /*     0    32 */
> 	__be16                     id;                   /*    32     2 */
> 	__be16                     frag_off;             /*    34     2 */
> 	u8                         ihl;                  /*    36     1 */
> 	u8                         tos;                  /*    37     1 */
> 	u8                         ttl;                  /*    38     1 */
> 	u8                         protocol;             /*    39     1 */
> 	u8                         optlen;               /*    40     1 */
> 	u8                         flow_lbl[3];          /*    41     3 */
> 
> 	/* size: 48, cachelines: 1, members: 9 */
> 	/* padding: 4 */
> 	/* last cacheline: 48 bytes */
> };
> 
> flow_lbl ends at 44, so adding orig_mac_len should be fine. I don't
> see any config options that would increase the size of
> xfrm_mode_skb_cb compared to what I already have.

Right, I overlooked the 4 byte padding in the pahole output.