netdev - Re: [PATCH v3] tcp: Add memory barrier to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240422161656.60331-1-dipiets@amazon.com>
Date: Mon, 22 Apr 2024 09:16:56 -0700
From: Salvatore Dipietro <dipiets@...zon.com>
To: <edumazet@...gle.com>
CC: <alisaidi@...zon.com>, <benh@...zon.com>, <blakgeof@...zon.com>,
	<davem@...emloft.net>, <dipietro.salvatore@...il.com>, <dipiets@...zon.com>,
	<dsahern@...nel.org>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH v3] tcp: Add memory barrier to tcp_push()

We have tested the proposed solution and it doesn't introduce any regression in our benchmark. 
Moreover, looking to the assembly code, the `test_and_set_bit` generates an `ldsetal` and `dmb ish` instructions which are correct for the ARM architecture.
We do not see any concern with the proposed patch.