netdev - Re: [PATCH io_uring-next/net-next v2 2/4] net: add callback for setting a ubuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <662697cf21177_753929488@willemb.c.googlers.com.notmuch>
Date: Mon, 22 Apr 2024 13:01:03 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Pavel Begunkov <asml.silence@...il.com>, 
 io-uring@...r.kernel.org, 
 netdev@...r.kernel.org
Cc: Jens Axboe <axboe@...nel.dk>, 
 asml.silence@...il.com, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 David Ahern <dsahern@...nel.org>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 Jason Wang <jasowang@...hat.com>, 
 Wei Liu <wei.liu@...nel.org>, 
 Paul Durrant <paul@....org>, 
 xen-devel@...ts.xenproject.org, 
 "Michael S . Tsirkin" <mst@...hat.com>, 
 virtualization@...ts.linux.dev, 
 kvm@...r.kernel.org
Subject: Re: [PATCH io_uring-next/net-next v2 2/4] net: add callback for
 setting a ubuf_info to skb

Pavel Begunkov wrote:
> At the moment an skb can only have one ubuf_info associated with it,
> which might be a performance problem for zerocopy sends in cases like
> TCP via io_uring. Add a callback for assigning ubuf_info to skb, this
> way we will implement smarter assignment later like linking ubuf_info
> together.
> 
> Note, it's an optional callback, which should be compatible with
> skb_zcopy_set(), that's because the net stack might potentially decide
> to clone an skb and take another reference to ubuf_info whenever it
> wishes. Also, a correct implementation should always be able to bind to
> an skb without prior ubuf_info, otherwise we could end up in a situation
> when the send would not be able to progress.
> 
> Reviewed-by: Jens Axboe <axboe@...nel.dk>
> Reviewed-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Pavel Begunkov <asml.silence@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>