netdev - Re: [patch net-next v5 3/5] selftests: forwarding: add check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiawyyOY-6radvXV@f4>
Date: Mon, 22 Apr 2024 14:47:39 -0400
From: Benjamin Poirier <benjamin.poirier@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, parav@...dia.com,
	mst@...hat.com, jasowang@...hat.com, xuanzhuo@...ux.alibaba.com,
	shuah@...nel.org, petrm@...dia.com, liuhangbin@...il.com,
	vladimir.oltean@....com, idosch@...dia.com,
	virtualization@...ts.linux.dev
Subject: Re: [patch net-next v5 3/5] selftests: forwarding: add
 check_driver() helper

On 2024-04-22 17:32 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Add a helper to be used to check if the netdevice is backed by specified
> driver.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 9d6802c6c023..00e089dd951d 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -278,10 +278,17 @@ check_port_mab_support()
>  	fi
>  }
>  
> -if [[ "$(id -u)" -ne 0 ]]; then
> -	echo "SKIP: need root privileges"
> -	exit $ksft_skip
> -fi

Why is the check being removed entirely? This change was not in v4 of
this patch. Did it happen unintentionally when removing "selftests:
forwarding: move initial root check to the beginning"?

> +check_driver()
> +{
> +	local dev=$1; shift
> +	local expected=$1; shift
> +	local driver_name=`driver_name_get $dev`
> +
> +	if [[ $driver_name != $expected ]]; then
> +		echo "SKIP: expected driver $expected for $dev, got $driver_name instead"
> +		exit $ksft_skip
> +	fi
> +}
>  
>  if [[ "$CHECK_TC" = "yes" ]]; then
>  	check_tc_version
> -- 
> 2.44.0
> 
>