netdev - Re: [PATCH net 2/2] Revert "net: txgbe: fix clk_name exceed MAX_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd03becb-678b-44de-b249-a66b37a9077d@intel.com>
Date: Mon, 22 Apr 2024 16:22:32 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Duanqiang Wen <duanqiangwen@...-swift.com>, <netdev@...r.kernel.org>,
	<jiawenwu@...stnetic.com>, <mengyuanlou@...-swift.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <maciej.fijalkowski@...el.com>, <andrew@...n.ch>
Subject: Re: [PATCH net 2/2] Revert "net: txgbe: fix clk_name exceed
 MAX_DEV_ID limits"



On 4/22/2024 1:41 AM, Duanqiang Wen wrote:
> This reverts commit e30cef001da259e8df354b813015d0e5acc08740.
> commit 99f4570cfba1 ("clkdev: Update clkdev id usage to allow
> for longer names") can fix clk_name exceed MAX_DEV_ID limits,
> so this commit is meaningless.
> 

The fix for longer names only adds 4 bytes, so it does fix this
particular case but doesn't necessarily resolve from having a future
issue if another name gets a bit longer.

Still, it makes sense to keep the original name now that it fits.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Signed-off-by: Duanqiang Wen <duanqiangwen@...-swift.com>
> ---
>  drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> index 5b5d5e4310d1..93295916b1d2 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> @@ -571,7 +571,7 @@ static int txgbe_clock_register(struct txgbe *txgbe)
>  	char clk_name[32];
>  	struct clk *clk;
>  
> -	snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d",
> +	snprintf(clk_name, sizeof(clk_name), "i2c_designware.%d",
>  		 pci_dev_id(pdev));
>  
>  	clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000);