netdev - Re: [PATCH net-next v3 2/2] net: dsa: mt7530: simplify core operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e67c66b-1d05-40d4-930f-625acc317ff1@arinc9.com>
Date: Tue, 23 Apr 2024 12:12:45 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Paolo Abeni <pabeni@...hat.com>, Daniel Golle <daniel@...rotopia.org>,
 DENG Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com>,
 Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Bartel Eerdekens <bartel.eerdekens@...stell8.be>,
 mithat.guner@...ont.com, erkin.bozoglu@...ont.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next v3 2/2] net: dsa: mt7530: simplify core
 operations

On 23/04/2024 11:40, Paolo Abeni wrote:
> On Thu, 2024-04-18 at 08:35 +0300, Arınç ÜNAL wrote:
>>   	/* Select the Function : DATA with no post increment */
>>   	ret = bus->write(bus, MT753X_CTRL_PHY_ADDR(priv->mdiodev->addr),
>> -			 MII_MMD_CTRL, devad | MII_MMD_CTRL_NOINCR);
>> +			 MII_MMD_CTRL, MDIO_MMD_VEND2 | MII_MMD_CTRL_NOINCR);
>>   	if (ret < 0)
>>   		goto err;
> 
> What about a possible follow-up, moving the above writes in a separate
> helper (say, 'core_select_register' or the like) and reusing it here
> and in core_rmw() ?

There's a possibility where the Clause 45 access method could be used here
which would make this redundant. I will do your suggestion if that won't
work out.

> 
> Not blocking this series, I'm applying it.

Cheers.
Arınç