netdev - Re: [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zieq42gpRYoOFhgM@Antony2201.local>
Date: Tue, 23 Apr 2024 14:34:43 +0200
From: Antony Antony <antony@...nome.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Antony Antony <antony.antony@...unet.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	devel@...ux-ipsec.org, Leon Romanovsky <leon@...nel.org>,
	Eyal Birger <eyal.birger@...il.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute
 for SA

On Mon, Apr 22, 2024 at 06:05:38AM -0700, Jakub Kicinski via Devel wrote:
> On Mon, 22 Apr 2024 00:23:58 +0200 Antony Antony wrote:
> > Hi,
> > 
> > Inspired by the upcoming IP-TFS patch set, and confusions experienced in
> > the past due to lack of direction attribute on SAs, add a new direction
> > "dir" attribute. It aims to streamline the SA configuration process and
> > enhance the clarity of existing SA attributes.
> > 
> > This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
> > ('in' for input or 'out' for output). Alsp add validations of existing
> > direction-specific SA attributes during configuration and in the data
> > path lookup.
> > 
> > This change would not affect any existing use case or way of configuring
> > SA. You will notice improvements when the new 'dir' attribute is set.
> 
> This breaks the xfrm_policy.sh selftests.

I mised spd lookup use diffrent nla_policy array than xfrma_policy.
I fixed it in v12.


> -- 
> pw-bot: au
> --