netdev - Re: [PATCH net v2 2/4] ethernet: Add helper for assigning packet type when dest address does not match device address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zie84KZ--UBnBydc@hog>
Date: Tue, 23 Apr 2024 15:51:28 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Gal Pressman <gal@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Yossi Kuperman <yossiku@...dia.com>,
	Benjamin Poirier <bpoirier@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net v2 2/4] ethernet: Add helper for assigning packet
 type when dest address does not match device address

2024-04-19, 14:30:17 -0700, Rahul Rameshbabu wrote:
> Enable reuse of logic in eth_type_trans for determining packet type.
> 
> Suggested-by: Sabrina Dubroca <sd@...asysnail.net>
> Cc: stable@...r.kernel.org
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> ---
>  include/linux/etherdevice.h | 24 ++++++++++++++++++++++++
>  net/ethernet/eth.c          | 12 +-----------
>  2 files changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index 224645f17c33..f5868ac69dec 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
> @@ -607,6 +607,30 @@ static inline void eth_hw_addr_gen(struct net_device *dev, const u8 *base_addr,
>  	eth_hw_addr_set(dev, addr);
>  }
>  
> +/**
> + * eth_skb_pkt_type - Assign packet type if destination address does not match
> + * @skb: Assigned a packet type if address does not match @dev address
> + * @dev: Network device used to compare packet address against
> + *
> + * If the destination MAC address of the packet does not match the network
> + * device address, assign an appropriate packet type.
> + */
> +static inline void eth_skb_pkt_type(struct sk_buff *skb, struct net_device *dev)

Could you make dev const? Otherwise the series looks good to me.

Thanks.

-- 
Sabrina