netdev - Re: [PATCH net] net: usb: ax88179_178a: stop lying about skb->truesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240423184008.GZ42092@kernel.org>
Date: Tue, 23 Apr 2024 19:40:08 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	shironeko <shironeko@...aguri.club>,
	Jose Alonso <joalonsof@...il.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH net] net: usb: ax88179_178a: stop lying about
 skb->truesize

On Sun, Apr 21, 2024 at 07:38:28PM +0000, Eric Dumazet wrote:
> Some usb drivers try to set small skb->truesize and break
> core networking stacks.
> 
> In this patch, I removed one of the skb->truesize overide.
> 
> I also replaced one skb_clone() by an allocation of a fresh
> and small skb, to get minimally sized skbs, like we did
> in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize
> in rx path")
> 
> Fixes: f8ebb3ac881b ("net: usb: ax88179_178a: Fix packet receiving")
> Reported-by: shironeko <shironeko@...aguri.club>
> Closes: https://lore.kernel.org/netdev/c110f41a0d2776b525930f213ca9715c@tesaguri.club/
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jose Alonso <joalonsof@...il.com>
> Cc: linux-usb@...r.kernel.org

Reviewed-by: Simon Horman <horms@...nel.org>