netdev - Re: [PATCH net 2/4] i40e: Report MFS in decimal base instead of hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485d3612-388f-1d7a-f6e7-3d94d46bab16@intel.com>
Date: Tue, 23 Apr 2024 11:46:05 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<edumazet@...gle.com>, <netdev@...r.kernel.org>
CC: Erwan Velu <e.velu@...teo.com>, Simon Horman <horms@...nel.org>, "Tony
 Brelinski" <tony.brelinski@...el.com>
Subject: Re: [PATCH net 2/4] i40e: Report MFS in decimal base instead of hex



On 4/23/2024 11:27 AM, Tony Nguyen wrote:
> From: Erwan Velu <e.velu@...teo.com>
> 
> If the MFS is set below the default (0x2600), a warning message is
> reported like the following :
> 
> 	MFS for port 1 has been set below the default: 600
> 
> This message is a bit confusing as the number shown here (600) is in
> fact an hexa number: 0x600 = 1536
> 
> Without any explicit "0x" prefix, this message is read like the MFS is
> set to 600 bytes.
> 
> MFS, as per MTUs, are usually expressed in decimal base.
> 
> This commit reports both current and default MFS values in decimal
> so it's less confusing for end-users.
> 
> A typical warning message looks like the following :
> 
> 	MFS for port 1 (1536) has been set below the default (9728)
> 

Sorry, I forgot to add the Fixes in.

Fixes: 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set")

Let me know if this is ok or if you'd like me to re-send with this added.

Thanks,
Tony

> Signed-off-by: Erwan Velu <e.velu@...teo.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Tested-by: Tony Brelinski <tony.brelinski@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 1792491d8d2d..ffb9f9f15c52 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -16107,8 +16107,8 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	val = FIELD_GET(I40E_PRTGL_SAH_MFS_MASK,
>   			rd32(&pf->hw, I40E_PRTGL_SAH));
>   	if (val < MAX_FRAME_SIZE_DEFAULT)
> -		dev_warn(&pdev->dev, "MFS for port %x has been set below the default: %x\n",
> -			 pf->hw.port, val);
> +		dev_warn(&pdev->dev, "MFS for port %x (%d) has been set below the default (%d)\n",
> +			 pf->hw.port, val, MAX_FRAME_SIZE_DEFAULT);
>   
>   	/* Add a filter to drop all Flow control frames from any VSI from being
>   	 * transmitted. By doing so we stop a malicious VF from sending out