netdev - Re: [PATCH net-next 0/8] net: dsa: b53: Remove adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9df504be-e907-437f-8f26-6e2cbb3997a2@broadcom.com>
Date: Tue, 23 Apr 2024 12:15:49 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/8] net: dsa: b53: Remove adjust_link

On 4/23/24 12:14, Russell King (Oracle) wrote:
> On Tue, Apr 23, 2024 at 11:33:31AM -0700, Florian Fainelli wrote:
>> b53 is now the only remaining driver that uses both PHYLIB's adjust_link
>> and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK.
>>
>> Florian Fainelli (8):
>>    net: dsa: b53: Stop exporting b53_phylink_* routines
>>    net: dsa: b53: Introduce b53_adjust_531x5_rgmii()
>>    net: dsa: b53: Introduce b53_adjust_5325_mii()
>>    net: dsa: b53: Force flow control for BCM5301X CPU port(s)
>>    net: dsa: b53: Configure RGMII for 531x5 and MII for 5325
>>    net: dsa: b53: Call b53_eee_init() from b53_mac_link_up()
>>    net: dsa: b53: Remove b53_adjust_link()
>>    net: dsa: b53: provide own phylink MAC operations
> 
> Read through the series, nothing obvious stands out, thanks for doing
> this!

And thank you for the reminder this needed to be done, once this lands I 
will submit the removal of the adjust_link within net/dsa/, unless you 
have that queued up already ready to go?

> 
> For the series:
> 
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> 

-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)