netdev - Re: [PATCH net-next v5 0/9] virtio-net: support device stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1713851675.6547418-3-xuanzhuo@linux.alibaba.com>
Date: Tue, 23 Apr 2024 13:54:35 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Stanislav Fomichev <sdf@...gle.com>,
 Amritha Nambiar <amritha.nambiar@...el.com>,
 Larysa Zaremba <larysa.zaremba@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 virtualization@...ts.linux.dev,
 bpf@...r.kernel.org
Subject: Re: [PATCH net-next v5 0/9] virtio-net: support device stats

On Mon, 22 Apr 2024 16:33:01 -0400, "Michael S. Tsirkin" <mst@...hat.com> wrote:
> On Mon, Mar 18, 2024 at 07:05:53PM +0800, Xuan Zhuo wrote:
> > As the spec:
> >
> > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
> >
> > The virtio net supports to get device stats.
> >
> > Please review.
>
> series:
>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
>
> I think you can now repost for net-next.

Thanks for your ack.

I and Jason discussed  a way to remove the "maps".

I will post a new patch set with that.

Thanks.

>
>
> > Thanks.
> >
> > v5:
> >     1. Fix some small problems in last version
> >     2. Not report stats that will be reported by netlink
> >     3. remove "_queue" from  ethtool -S
> >
> > v4:
> >     1. Support per-queue statistics API
> >     2. Fix some small problems in last version
> >
> > v3:
> >     1. rebase net-next
> >
> > v2:
> >     1. fix the usage of the leXX_to_cpu()
> >     2. add comment to the structure virtnet_stats_map
> >
> > v1:
> >     1. fix some definitions of the marco and the struct
> >
> >
> >
> >
> >
> >
> > Xuan Zhuo (9):
> >   virtio_net: introduce device stats feature and structures
> >   virtio_net: virtnet_send_command supports command-specific-result
> >   virtio_net: remove "_queue" from ethtool -S
> >   virtio_net: support device stats
> >   virtio_net: stats map include driver stats
> >   virtio_net: add the total stats field
> >   virtio_net: rename stat tx_timeout to timeout
> >   netdev: add queue stats
> >   virtio-net: support queue stat
> >
> >  Documentation/netlink/specs/netdev.yaml | 104 ++++
> >  drivers/net/virtio_net.c                | 755 +++++++++++++++++++++---
> >  include/net/netdev_queues.h             |  27 +
> >  include/uapi/linux/netdev.h             |  19 +
> >  include/uapi/linux/virtio_net.h         | 143 +++++
> >  net/core/netdev-genl.c                  |  23 +-
> >  tools/include/uapi/linux/netdev.h       |  19 +
> >  7 files changed, 1013 insertions(+), 77 deletions(-)
> >
> > --
> > 2.32.0.3.g01195cf9f
>