netdev - Re: [PATCH 1/3] s390/vmlogrdr: Remove function pointer cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b836dbb-98a1-484a-b88c-4beff45f2685@linux.ibm.com>
Date: Tue, 23 Apr 2024 09:34:12 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>
Cc: Thorsten Winkler <twinkler@...ux.ibm.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>, gor@...ux.ibm.com,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, llvm@...ts.linux.dev,
        patches@...ts.linux.dev
Subject: Re: [PATCH 1/3] s390/vmlogrdr: Remove function pointer cast



On 19.04.24 16:12, Heiko Carstens wrote:
> On Fri, Apr 19, 2024 at 02:19:14PM +0200, Arnd Bergmann wrote:
>> On Fri, Apr 19, 2024, at 14:15, Heiko Carstens wrote:
>>>
>>> Plus we need to fix the potential bug you introduced with commit
>>> 42af6bcbc351 ("tty: hvc-iucv: fix function pointer casts"). But at
>>> least this is also iucv_bus related.
>>>
>>> Alexandra, Thorsten, any objections if CONFIG_IUCV would be changed so
>>> it can only be compiled in or out, but not as a module anymore?
>>
>> You can also just drop the iucv_exit() function, making the
>> module non-removable when it has an init function but no exit.
> 
> Right, that's better, and also what I did back then for the zfcp
> module for the same reason.
> 

Heiko,
as discussed f2f: 'no module' or 'non-removable module'
both options are fine with me. I would prefer non-removable.
Both are better than calling removed functions.

This also applies to patches 2 and 3 of this series:
drivers/s390/net/smsgiucv_app.c
drivers/s390/net/netiucv.c

Thank you
Alexandra