netdev - [PATCH net-next] r8152: replace dev_info with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB447451E4C0CECE275218336CDE102@PH0PR18MB4474.namprd18.prod.outlook.com>
Date: Wed, 24 Apr 2024 09:04:21 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Hayes Wang <hayeswang@...ltek.com>, "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nic_swsd@...ltek.com"
	<nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>
Subject: [PATCH net-next] r8152: replace dev_info with dev_dbg for loading
 firmware



> Someone complains the message appears continuously. This occurs because
> the device is woken from UPS mode, and the driver re-loads the firmware.
> 
> When the device enters runtime suspend and cable is unplugged, the device
> would enter UPS mode. If the runtime resume occurs, and the device is
> woken from UPS mode, the driver has to re-load the firmware and causes the
> message. If someone wakes the device continuously, the message would be
> shown continuously, too. Use dev_dbg to avoid it.
> 
> Note that, the function could be called before register_netdev(), so I don't use
> netif_info() or netif_dbg().
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> ---
>  drivers/net/usb/r8152.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index
> 5d6aeb086fc7..51e9f5b2dccf 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -5274,7 +5274,7 @@ static void rtl8152_apply_firmware(struct r8152 *tp,
> bool power_cut)
> 
>  	rtl_reset_ocp_base(tp);
>  	strscpy(rtl_fw->version, fw_hdr->version, RTL_VER_SIZE);
> -	dev_info(&tp->intf->dev, "load %s successfully\n", rtl_fw->version);
> +	dev_dbg(&tp->intf->dev, "load %s successfully\n", rtl_fw->version);
Since enabling dev_dbg involves re-compiling kernel if CONFIG_DYNAMIC_DEBUG not enabled,
 Does it make sense to use  "dev_info_ratelimited" here.

Thanks,
Hariprasad k
>  }
> 
>  static void rtl8152_release_firmware(struct r8152 *tp)
> --
> 2.44.0
>