netdev - Re: [PATCH net-next] tools: testing: selftests: switch conntrack_dump_flush to TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 11:55:23 +0200
From: Florian Westphal <fw@...len.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, netfilter-devel@...r.kernel.org,
	pablo@...filter.org
Subject: Re: [PATCH net-next] tools: testing: selftests: switch
 conntrack_dump_flush to TEST_PROGS

Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 22 Apr 2024 17:26:59 +0200 Florian Westphal wrote:
> > Currently conntrack_dump_flush test program always runs when passing
> > TEST_PROGS argument:
> > 
> > % make -C tools/testing/selftests TARGETS=net/netfilter TEST_PROGS=conntrack_ipip_mtu.sh run_tests
> > make: Entering [..]
> > TAP version 13
> > 1..2 [..]
> >   selftests: net/netfilter: conntrack_dump_flush [..]
> > 
> > Move away from TEST_CUSTOM_PROGS to avoid this.  After this,
> > above command will only run the program specified in TEST_PROGS.
> 
> Hm, but why TEST_CUSTOM_PROGS in the first place?
> What's special about it? I think TEST_GEN_PROGS would work

It works iff I run 'make -C tools/testing/selftests TARGETS=net/netfilter'
before running vng ... make -C tools/testing/selftests
TARGETS=net/netfilter  TEST_PROGS=conntrack_dump_flush TEST_GEN_PROGS="" run_tests.

I'll send a v2, will check if it works in the CI or not.