netdev - Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020 internal PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5426c24a215b363e7b9b03a97d023d2e29b6a0a7.camel@ew.tq-group.com>
Date: Wed, 24 Apr 2024 16:57:24 +0200
From: Matthias Schiffer <matthias.schiffer@...tq-group.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>,  "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux@...tq-group.com
Subject: Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020
 internal PHYs

On Wed, 2024-04-24 at 16:52 +0200, Andrew Lunn wrote:
> > We currently do not override the PHY ID for this family in the DSA
> > driver - my understanding was that this is only necessary for
> > switches that don't provide a usable PHY ID at all. As I have no
> > idea if this PHY ID works for the whole family or just the single
> > switch, I went with the more specific naming here.
> 
> The 'broken' switches have the Marvell OUI, but no module number. From
> your description it sounds like the 6250 is the same?
> 

No, the PHYs have a proper ID, 0x01410db0. The "Functional Spec" for the 88E6020 switch family gives
us the 0x01410c00 part, but the lower 10 bits are undocumented ("reserved"), and I don't know if
they differ for each individual switch of the family, as I only have a 88E6020 here.

Matthias

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/