netdev - Re: [PATCH net v4] net: b44: set pause params only when interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLik=ZiFd2hS8Nt+pd-mYboFb5sypW8vpe_9NXD4W7yHv6A@mail.gmail.com>
Date: Wed, 24 Apr 2024 09:37:29 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Peter Münster <pm@...n.net>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net v4] net: b44: set pause params only when interface is up

On Wed, Apr 24, 2024 at 6:51 AM Peter Münster <pm@...n.net> wrote:
>
> b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
> unconditionally, but b44::rx_buffers is only valid when the
> device is up (they get allocated in b44_open(), and deallocated
> again in b44_close()), any other time these are just a NULL pointers.
>
> So if you try to change the pause params while the network interface
> is disabled/administratively down, everything explodes (which likely
> netifd tries to do).
>
> Link: https://github.com/openwrt/openwrt/issues/13789
> Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
> Cc: stable@...r.kernel.org
> Reported-by: Peter Münster <pm@...n.net>
> Suggested-by: Jonas Gorski <jonas.gorski@...il.com>
> Signed-off-by: Vaclav Svoboda <svoboda@...g.cz>
> Tested-by: Peter Münster <pm@...n.net>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Peter Münster <pm@...n.net>

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)