netdev - Re: [PATCH v1 net-next] af_unix: Suppress false-positive lockdep splat for spin_lock() in __unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240424022136.20484-1-kuniyu@amazon.com>
Date: Tue, 23 Apr 2024 19:21:36 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuniyu@...zon.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <mhal@...x.co>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <syzbot+fa379358c28cc87cc307@...kaller.appspotmail.com>
Subject: Re: [PATCH v1 net-next] af_unix: Suppress false-positive lockdep splat for spin_lock() in __unix_gc().

From: Kuniyuki Iwashima <kuniyu@...zon.com>
Date: Tue, 23 Apr 2024 18:26:48 -0700
> syzbot reported a lockdep splat regarding unix_gc_lock() and
> unix_state_lock().
> 
> One is called from recvmsg() for a connected socket, and another
> is called from GC for TCP_LISTEN socket.
> 
> So, the splat is false-positive.
> 
> Let's add a dedicated lock class for the latter to suppress the splat.
> 
> Note that this change is not necessary for net-next.git as the issue
> is only applied to the old GC impl.
> 

Sorry, I wrongly tagged net-next..

will resend v2.

pw-bot: cr