netdev - Re: [PATCH net-next 1/4] selftests: drv-net: force pseudo-terminal allocation in ssh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 15:56:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 linux-kselftest@...r.kernel.org, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next 1/4] selftests: drv-net: force pseudo-terminal
 allocation in ssh

On Wed, 24 Apr 2024 15:14:41 -0700 Jakub Kicinski wrote:
> This is not yet needed, because we don't terminate remote background
> commands. But once we do, if we run ssh without -t the ssh session
> may close and the program may carry on happily running.
> 
> I have hit this problem experimenting with mausezahn, let's fix
> it already to avoid someone else wasting time debugging it.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  tools/testing/selftests/drivers/net/lib/py/remote_ssh.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py
> index 924addde19a3..294a4ed8284e 100644
> --- a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py
> +++ b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py
> @@ -20,7 +20,7 @@ from lib.py import cmd
>              self._tmpdir = None
>  
>      def cmd(self, comm):
> -        return subprocess.Popen(["ssh", "-q", self.name, comm],
> +        return subprocess.Popen(["ssh", "-t", "-q", self.name, comm],
>                                  stdout=subprocess.PIPE, stderr=subprocess.PIPE)

This seems to mess up the local terminal. I guess we'll cross that
bridge when we get there... I'll drop this patch when applying.