netdev - Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a837ef60-d209-4f97-81b3-e29945f20f28@ti.com>
Date: Wed, 24 Apr 2024 13:58:00 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Roger Quadros <rogerq@...com>
CC: Roger Quadros <rogerq@...nel.org>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
	<andrew@...n.ch>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Diogo Ivo
	<diogo.ivo@...mens.com>, Rob Herring <robh@...nel.org>,
        Grygorii Strashko
	<grygorii.strashko@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in
 prueth_init_rx_chns()



On 23/04/24 9:45 pm, Dan Carpenter wrote:
> The rx_chn->irq[] array is unsigned int but it should be signed for the
> error handling to work.  Also if k3_udma_glue_rx_get_irq() returns zero
> then we should return -ENXIO instead of success.
> 
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: MD Danish Anwar <danishanwar@...com>

-- 
Thanks and Regards,
Danish