netdev - Re: [PATCH net-next] tcp: fix tcp_grow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Apr 2024 16:34:22 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: fix tcp_grow_skb() vs tstamps

On Thu, Apr 25, 2024 at 3:34 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> I forgot to call tcp_skb_collapse_tstamp() in the
> case we consume the second skb in write queue.
>
> Neal suggested to create a common helper used by tcp_mtu_probe()
> and tcp_grow_skb().
>
> Fixes: 8ee602c63520 ("tcp: try to send bigger TSO packets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Great. Thanks, Eric!

neal