netdev - Re: [PATCH net-next 1/6] devlink: extend devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240424200858.1d0740a4@kernel.org>
Date: Wed, 24 Apr 2024 20:08:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Mateusz Polchlopek <mateusz.polchlopek@...el.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, <davem@...emloft.net>, <pabeni@...hat.com>,
 <edumazet@...gle.com>, <netdev@...r.kernel.org>, Jiri Pirko
 <jiri@...dia.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next 1/6] devlink: extend devlink_param *set pointer

On Wed, 24 Apr 2024 11:05:58 +0200 Alexander Lobakin wrote:
> >  	int (*set)(struct devlink *devlink, u32 id,
> > -		   struct devlink_param_gset_ctx *ctx);
> > +		   struct devlink_param_gset_ctx *ctx,
> > +		   struct netlink_ext_ack *extack);  
> 
> Sorry for the late comment. Can't we embed extack to
> devlink_param_gset_ctx instead? It would take much less lines.

I think the way Mateusz wrote this is more prevalent today.
Also feels a tiny bit cleaner to me, because if we embed
extack why is devlink and id not embedded?

We've seen this series enough times, let me apply this as is..
Please follow up with the doc adjustments if you'd like, separately.