netdev - Re: [PATCH net-next 2/2] tcp: update sacked after tracepoint in __tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJb2XkPwYfjJnhfU5pvf_jjD-xw5WuzDom8GP+t5nzyMw@mail.gmail.com>
Date: Thu, 25 Apr 2024 08:25:31 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Philo Lu <lulie@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net, 
	martin.lau@...ux.dev, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, 
	kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, 
	xuanzhuo@...ux.alibaba.com, fred.cc@...baba-inc.com
Subject: Re: [PATCH net-next 2/2] tcp: update sacked after tracepoint in __tcp_retransmit_skb

On Sun, Apr 21, 2024 at 6:20 AM Philo Lu <lulie@...ux.alibaba.com> wrote:
>
> Marking TCP_SKB_CB(skb)->sacked with TCPCB_EVER_RETRANS after the
> traceopint (trace_tcp_retransmit_skb), then we can get the
> retransmission efficiency by counting skbs w/ and w/o TCPCB_EVER_RETRANS
> mark in this tracepoint.
>
> We have discussed to achieve this with BPF_SOCK_OPS in [0], and using
> tracepoint is thought to be a better solution.
>
> [0]
> https://lore.kernel.org/all/20240417124622.35333-1-lulie@linux.alibaba.com/
>
> Signed-off-by: Philo Lu <lulie@...ux.alibaba.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>