netdev - Re: [PATCH net-next v6 8/8] virtio-net: support queue stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1714029274.2610173-1-xuanzhuo@linux.alibaba.com>
Date: Thu, 25 Apr 2024 15:14:34 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>,
 Eric  Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 "Michael S.  Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Alexei  Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Stanislav Fomichev <sdf@...gle.com>,
 Amritha  Nambiar <amritha.nambiar@...el.com>,
 Larysa Zaremba <larysa.zaremba@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 virtualization@...ts.linux.dev,
 bpf@...r.kernel.org
Subject: Re: [PATCH net-next v6 8/8] virtio-net: support queue stat

On Wed, 24 Apr 2024 20:44:22 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Tue, 23 Apr 2024 19:31:41 +0800 Xuan Zhuo wrote:
> > +static void virtnet_get_base_stats(struct net_device *dev,
> > +				   struct netdev_queue_stats_rx *rx,
> > +				   struct netdev_queue_stats_tx *tx)
> > +{
> > +	/* The queue stats of the virtio-net will not be reset. So here we
> > +	 * return 0.
> > +	 */
> > +	rx->bytes = 0;
> > +	rx->packets = 0;
> > +	rx->alloc_fail = 0;
> > +	rx->hw_drops = 0;
> > +	rx->hw_drop_overruns = 0;
> > +	rx->csum_unnecessary = 0;
> > +	rx->csum_none = 0;
> > +	rx->csum_bad = 0;
> > +	rx->hw_gro_packets = 0;
> > +	rx->hw_gro_bytes = 0;
> > +	rx->hw_gro_wire_packets = 0;
> > +	rx->hw_gro_wire_bytes = 0;
> > +	rx->hw_drop_ratelimits = 0;
> > +
> > +	tx->bytes = 0;
> > +	tx->packets = 0;
> > +	tx->hw_drops = 0;
> > +	tx->hw_drop_errors = 0;
> > +	tx->csum_none = 0;
> > +	tx->needs_csum = 0;
> > +	tx->hw_gso_packets = 0;
> > +	tx->hw_gso_bytes = 0;
> > +	tx->hw_gso_wire_packets = 0;
> > +	tx->hw_gso_wire_bytes = 0;
> > +	tx->hw_drop_ratelimits = 0;
>
> Doesn't this need to be conditional based on device capabilities?
> We should only assign the stats that the device is collecting
> (both in base stats and per-queue).

Will be fixed in next version.

Thanks.