netdev - Re: [PATCH net-next 00/12] gtp updates for net-next (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240425192944.67c99bdf@kernel.org>
Date: Thu, 25 Apr 2024 19:29:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, laforge@...ocom.org,
 pespin@...mocom.de, osmith@...mocom.de, pabeni@...hat.com,
 edumazet@...gle.com, fw@...len.de
Subject: Re: [PATCH net-next 00/12] gtp updates for net-next (v2)

On Thu, 25 Apr 2024 12:51:26 +0200 Pablo Neira Ayuso wrote:
> This v2 includes a sparse fix for patch #5 reported by Jakub.

Sorry one more semi-automated compiler warning, clang has this to
say about patch 12:

../drivers/net/gtp.c:606:14: warning: variable 'pctx' is uninitialized when used here [-Wuninitialized]
  606 |                 netdev_dbg(pctx->dev, "GTP packet does not encapsulate an IP packet\n");
      |                            ^~~~
../include/net/net_debug.h:57:21: note: expanded from macro 'netdev_dbg'
   57 |         dynamic_netdev_dbg(__dev, format, ##args);              \
      |                            ^~~~~
../include/linux/dynamic_debug.h:278:7: note: expanded from macro 'dynamic_netdev_dbg'
  278 |                            dev, fmt, ##__VA_ARGS__)
      |                            ^~~
../include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
  250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
      |                                                                  ^~~~~~~~~~~
../include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
  248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
      |                                                                        ^~~~~~~~~~~
../include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
  224 |                 func(&id, ##__VA_ARGS__);                       \
      |                             ^~~~~~~~~~~
../drivers/net/gtp.c:581:22: note: initialize the variable 'pctx' to silence this warning
  581 |         struct pdp_ctx *pctx;
      |                             ^
      |                              = NULL
../drivers/net/gtp.c:825:14: warning: variable 'pctx' is uninitialized when used here [-Wuninitialized]
  825 |                 netdev_dbg(pctx->dev, "GTP packet does not encapsulate an IP packet\n");
      |                            ^~~~
../include/net/net_debug.h:57:21: note: expanded from macro 'netdev_dbg'
   57 |         dynamic_netdev_dbg(__dev, format, ##args);              \
      |                            ^~~~~
../include/linux/dynamic_debug.h:278:7: note: expanded from macro 'dynamic_netdev_dbg'
  278 |                            dev, fmt, ##__VA_ARGS__)
      |                            ^~~
../include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
  250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
      |                                                                  ^~~~~~~~~~~
../include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
  248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
      |                                                                        ^~~~~~~~~~~
../include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
  224 |                 func(&id, ##__VA_ARGS__);                       \
      |                             ^~~~~~~~~~~
../drivers/net/gtp.c:787:22: note: initialize the variable 'pctx' to silence this warning
  787 |         struct pdp_ctx *pctx;
      |                             ^
      |                              = NULL