netdev - Re: [PATCH net-next v12 09/15] net: stmmac: dwmac-loongson: Add phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36afcb40-7e09-4a17-ad12-c27ac50120e1@loongson.cn>
Date: Fri, 26 Apr 2024 18:16:42 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, fancer.lancer@...il.com,
 Jose.Abreu@...opsys.com, chenhuacai@...nel.org, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 09/15] net: stmmac: dwmac-loongson: Add
 phy_interface for Loongson GMAC

Hi Russell,

在 2024/4/25 22:36, Russell King (Oracle) 写道:
>> The mac_interface of gmac is PHY_INTERFACE_MODE_RGMII_ID.
> No it isn't!
Ok, that's a typo.
>
>> +	plat->phy_interface = PHY_INTERFACE_MODE_RGMII_ID;
> You don't touch mac_interface here. Please read the big comment I put
> in include/linux/stmmac.h above these fields in struct
> plat_stmmacenet_data to indicate what the difference between
> mac_interface and phy_interface are, and then correct which-ever
> of the above needs to be corrected.

Copy your big comment here:

     int phy_addr;
     /* MAC ----- optional PCS ----- SerDes ----- optional PHY ----- Media
      *       ^                               ^
      * mac_interface                   phy_interface
      *
      * mac_interface is the MAC-side interface, which may be the same
      * as phy_interface if there is no intervening PCS. If there is a
      * PCS, then mac_interface describes the interface mode between the
      * MAC and PCS, and phy_interface describes the interface mode
      * between the PCS and PHY.
      */
     phy_interface_t mac_interface;
     /* phy_interface is the PHY-side interface - the interface used by
      * an attached PHY.
      */

Our hardware engineer said we don't support pcs, and if I understand

your comment correctly, our mac_interface and phy_interface should

be the same, right?

Thanks,

Yanteng