netdev - Re: [PATCH net-next] ipv6: introduce dst_rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fa615a8-3b5e-4cd2-ba76-f72d908c32b7@kernel.org>
Date: Fri, 26 Apr 2024 09:09:18 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] ipv6: introduce dst_rt6_info() helper

On 4/25/24 10:57 AM, Eric Dumazet wrote:
> Instead of (struct rt6_info *)dst casts, we can use :
> 
>  #define dst_rt6_info(_ptr) \
>          container_of_const(_ptr, struct rt6_info, dst)
> 
> Some places needed missing const qualifiers :
> 
> ip6_confirm_neigh(), ipv6_anycast_destination(),
> ipv6_unicast_destination(), has_gateway()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/infiniband/core/addr.c                |  6 ++--
>  .../ethernet/mellanox/mlxsw/spectrum_span.c   |  2 +-
>  drivers/net/vrf.c                             |  2 +-

missing drivers/net/vxlan/vxlan_core.c, vxlan_xmit_one

>  drivers/s390/net/qeth_core.h                  |  2 +-
>  include/net/ip6_fib.h                         |  6 ++--
>  include/net/ip6_route.h                       | 11 ++++----
>  net/bluetooth/6lowpan.c                       |  2 +-
>  net/core/dst_cache.c                          |  2 +-
>  net/core/filter.c                             |  2 +-
>  net/ipv4/ip_tunnel.c                          |  2 +-
>  net/ipv6/icmp.c                               |  8 +++---
>  net/ipv6/ila/ila_lwt.c                        |  4 +--
>  net/ipv6/ip6_output.c                         | 18 ++++++------
>  net/ipv6/ip6mr.c                              |  2 +-
>  net/ipv6/ndisc.c                              |  2 +-
>  net/ipv6/ping.c                               |  2 +-
>  net/ipv6/raw.c                                |  4 +--
>  net/ipv6/route.c                              | 28 +++++++++----------
>  net/ipv6/tcp_ipv6.c                           |  4 +--
>  net/ipv6/udp.c                                | 11 +++-----
>  net/ipv6/xfrm6_policy.c                       |  2 +-
>  net/l2tp/l2tp_ip6.c                           |  2 +-
>  net/mpls/mpls_iptunnel.c                      |  2 +-
>  net/netfilter/ipvs/ip_vs_xmit.c               | 14 +++++-----
>  net/netfilter/nf_flow_table_core.c            |  8 ++----
>  net/netfilter/nf_flow_table_ip.c              |  4 +--
>  net/netfilter/nft_rt.c                        |  2 +-
>  net/sctp/ipv6.c                               |  2 +-
>  net/xfrm/xfrm_policy.c                        |  3 +-
>  29 files changed, 75 insertions(+), 84 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>