netdev - Re: [PATCH net-next] tools: ynl: don't append doc of missing type directly to the type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2sez8f8og.fsf@gmail.com>
Date: Fri, 26 Apr 2024 16:25:03 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com
Subject: Re: [PATCH net-next] tools: ynl: don't append doc of missing type
 directly to the type

Jakub Kicinski <kuba@...nel.org> writes:

> When using YNL in tests appending the doc string to the type
> name makes it harder to check that we got the correct error.
> Put the doc under a separate key.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>

> ---
>  tools/net/ynl/lib/ynl.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> index 35f82a2c2247..35e666928119 100644
> --- a/tools/net/ynl/lib/ynl.py
> +++ b/tools/net/ynl/lib/ynl.py
> @@ -233,10 +233,9 @@ from .nlspec import SpecFamily
>                      miss_type = self.extack['miss-type']
>                      if miss_type in attr_space.attrs_by_val:
>                          spec = attr_space.attrs_by_val[miss_type]
> -                        desc = spec['name']
> +                        self.extack['miss-type'] = spec['name']
>                          if 'doc' in spec:
> -                            desc += f" ({spec['doc']})"
> -                        self.extack['miss-type'] = desc
> +                            self.extack['miss-type-doc'] = spec['doc']
>  
>      def _decode_policy(self, raw):
>          policy = {}