netdev - Re: [RFC PATCH bpf-next v5 2/2] net: Add additional bit to support clockid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c20eb574-22f4-49f8-a213-5ff57eb6222e@linux.dev>
Date: Fri, 26 Apr 2024 16:55:57 -0700
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Abhishek Chauhan <quic_abchauha@...cinc.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Andrew Halaney <ahalaney@...hat.com>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Martin KaFai Lau <martin.lau@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, bpf <bpf@...r.kernel.org>,
 kernel@...cinc.com
Subject: Re: [RFC PATCH bpf-next v5 2/2] net: Add additional bit to support
 clockid_t timestamp type

On 4/24/24 3:20 PM, Abhishek Chauhan wrote:
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index a9e819115622..63e4cc30d18d 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -955,7 +955,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>   			if (iter.frag)
>   				ip6_fraglist_prepare(skb, &iter);
>   
> -			skb_set_delivery_time(skb, tstamp, tstamp_type);
> +			skb_set_tstamp_type_frm_clkid(skb, tstamp, tstamp_type);
>   			err = output(net, sk, skb);
>   			if (!err)
>   				IP6_INC_STATS(net, ip6_dst_idev(&rt->dst),
> @@ -1016,7 +1016,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>   		/*
>   		 *	Put this fragment into the sending queue.
>   		 */
> -		skb_set_delivery_time(frag, tstamp, tstamp_type);
> +		skb_set_tstamp_type_frm_clkid(frag, tstamp, tstamp_type);
>   		err = output(net, sk, frag);
>   		if (err)
>   			goto fail;

When replying another thread and looking closer at the ip6 changes, these two 
line changes should not be needed.