netdev - Re: [PATCH v4 1/8] net: Remove the now superfluous sentinel elements from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240426065931.wyrzevlheburnf47@joelS2.panther.com>
Date: Fri, 26 Apr 2024 08:59:31 +0200
From: Joel Granados <j.granados@...sung.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>, Miquel Raynal
	<miquel.raynal@...tlin.com>, David Ahern <dsahern@...nel.org>, Steffen
	Klassert <steffen.klassert@...unet.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, Matthieu Baerts <matttbe@...nel.org>, Mat
	Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, Ralf
	Baechle <ralf@...ux-mips.org>, Remi Denis-Courmont <courmisch@...il.com>,
	Allison Henderson <allison.henderson@...cle.com>, David Howells
	<dhowells@...hat.com>, Marc Dionne <marc.dionne@...istor.com>, Marcelo
	Ricardo Leitner <marcelo.leitner@...il.com>, Xin Long
	<lucien.xin@...il.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher
	<jaka@...ux.ibm.com>, "D. Wythe" <alibuda@...ux.alibaba.com>, Tony Lu
	<tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>, Trond
	Myklebust <trond.myklebust@...merspace.com>, Anna Schumaker
	<anna@...nel.org>, Chuck Lever <chuck.lever@...cle.com>, Jeff Layton
	<jlayton@...nel.org>, Neil Brown <neilb@...e.de>, Olga Kornievskaia
	<kolga@...app.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
	<tom@...pey.com>, Jon Maloy <jmaloy@...hat.com>, Ying Xue
	<ying.xue@...driver.com>, Martin Schiller <ms@....tdt.de>, Pablo Neira Ayuso
	<pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, Florian
	Westphal <fw@...len.de>, Roopa Prabhu <roopa@...dia.com>, Nikolay
	Aleksandrov <razor@...ckwall.org>, Simon Horman <horms@...ge.net.au>, Julian
	Anastasov <ja@....bg>, Joerg Reuter <jreuter@...na.de>, Luis Chamberlain
	<mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<dccp@...r.kernel.org>, <linux-wpan@...r.kernel.org>,
	<mptcp@...ts.linux.dev>, <linux-hams@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <rds-devel@....oracle.com>,
	<linux-afs@...ts.infradead.org>, <linux-sctp@...r.kernel.org>,
	<linux-s390@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
	<tipc-discussion@...ts.sourceforge.net>, <linux-x25@...r.kernel.org>,
	<netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
	<bridge@...ts.linux.dev>, <lvs-devel@...r.kernel.org>
Subject: Re: [PATCH v4 1/8] net: Remove the now superfluous sentinel
 elements from ctl_table array

On Thu, Apr 25, 2024 at 03:58:04PM -0700, Jakub Kicinski wrote:
> On Thu, 25 Apr 2024 14:02:59 +0200 Joel Granados via B4 Relay wrote:
> > -	for (i = 0; i < ARRAY_SIZE(mpls_table) - 1; i++)
> > +	for (i = 0; i < tabel_size; i++)
> >  		table[i].data = (char *)net + (uintptr_t)table[i].data;
> >  
> >  	net->mpls.ctl = register_net_sysctl_sz(net, "net/mpls", table,
> > -					       ARRAY_SIZE(mpls_table));
> > +					       tabel_size);
> 
> ../net/mpls/af_mpls.c: In function ‘mpls_net_init’:
> ../net/mpls/af_mpls.c:2676:25: error: ‘tabel_size’ undeclared (first use in this function); did you mean ‘table_size’?
>  2676 |         for (i = 0; i < tabel_size; i++)
>       |                         ^~~~~~~~~~
>       |                         table_size
> ../net/mpls/af_mpls.c:2676:25: note: each undeclared identifier is reported only once for each function it appears in
> ../net/mpls/af_mpls.c:2660:16: warning: unused variable ‘table_size’ [-Wunused-variable]
>  2660 |         size_t table_size = ARRAY_SIZE(mpls_table);
Sorry about this. I pulled the trigger way too early. This is already
fixed in my v4.
>       |                ^~~~~~~~~~
> -- 
> netdev FAQ tl;dr:
>  - designate your patch to a tree - [PATCH net] or [PATCH net-next]
>  - for fixes the Fixes: tag is required, regardless of the tree
>  - don't post large series (> 15 patches), break them up
>  - don't repost your patches within one 24h period
> 
> pw-bot: cr

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)