netdev - Re: [PATCH ipsec-next v12 4/4] xfrm: Restrict SA direction attribute to specific netlink message types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZitcxrkIaOtatSdA@Antony2201.local>
Date: Fri, 26 Apr 2024 09:50:30 +0200
From: Antony Antony <antony@...nome.org>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: Antony Antony <antony.antony@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	devel@...ux-ipsec.org, Leon Romanovsky <leon@...nel.org>,
	Eyal Birger <eyal.birger@...il.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec-next v12 4/4] xfrm: Restrict SA direction attribute
 to specific netlink message types

On Fri, Apr 26, 2024 at 06:49:38AM +0200, Steffen Klassert via Devel wrote:
> On Tue, Apr 23, 2024 at 02:51:21PM +0200, Antony Antony wrote:
> > Reject the usage of the SA_DIR attribute in xfrm netlink messages when
> > it's not applicable. This ensures that SA_DIR is only accepted for
> > certain message types (NEWSA, UPDSA, and ALLOCSPI)
> > 
> > Signed-off-by: Antony Antony <antony.antony@...unet.com>
> > ---
> > v11 -> 12
> >      - fix spd look up. This broke xfrm_policy.sh tests
> > ---
> >  net/xfrm/xfrm_user.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
> > index d34ac467a219..5d8aac0e8a6f 100644
> > --- a/net/xfrm/xfrm_user.c
> > +++ b/net/xfrm/xfrm_user.c
> > @@ -3200,6 +3200,24 @@ static const struct xfrm_link {
> >  	[XFRM_MSG_GETDEFAULT  - XFRM_MSG_BASE] = { .doit = xfrm_get_default   },
> >  };
> > 
> > +static int xfrm_reject_unused(int type, struct nlattr **attrs,
> > +			      struct netlink_ext_ack *extack)
> 
> Maybe call that function xfrm_reject_unused_attr to make it clear
> what is unused here?

good idea. Fixed in v13