netdev - Re: [PATCH net-next v7 8/8] virtio-net: support queue stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240426172331.174483e6@kernel.org>
Date: Fri, 26 Apr 2024 17:23:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Michael S.
 Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Alexei
 Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, Stanislav Fomichev <sdf@...gle.com>, Amritha
 Nambiar <amritha.nambiar@...el.com>, Larysa Zaremba
 <larysa.zaremba@...el.com>, Sridhar Samudrala
 <sridhar.samudrala@...el.com>, Maciej Fijalkowski
 <maciej.fijalkowski@...el.com>, virtualization@...ts.linux.dev,
 bpf@...r.kernel.org
Subject: Re: [PATCH net-next v7 8/8] virtio-net: support queue stat

On Fri, 26 Apr 2024 11:39:28 +0800 Xuan Zhuo wrote:
> To enhance functionality, we now support reporting statistics through
> the netdev-generic netlink (netdev-genl) queue stats interface. However,
> this does not extend to all statistics, so a new field, qstat_offset,
> has been introduced. This field determines which statistics should be
> reported via netdev-genl queue stats.
> 
> Given that queue stats are retrieved individually per queue, it's
> necessary for the virtnet_get_hw_stats() function to be capable of
> fetching statistics for a specific queue.
> 
> As the document https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
> 
> We should not duplicate the stats which get reported via the netlink API in
> ethtool. If the stats are for queue stat, that will not be reported by
> ethtool -S.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thank you!