netdev - Re: [PATCH 1/2] [PATCH net-next,1/2] Add new args for cong_control in tcp_congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+HO59Sxwu2fhrKOJCX_3DjOPp+os0LOO3TjvrTdvEiyQ@mail.gmail.com>
Date: Sat, 27 Apr 2024 15:06:31 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Miao Xu <miaxu@...a.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Martin Lau <kafai@...a.com>, 
	netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 1/2] [PATCH net-next,1/2] Add new args for cong_control in tcp_congestion_ops

On Wed, Apr 24, 2024 at 10:38 PM Miao Xu <miaxu@...a.com> wrote:
>
> This patch adds two new arguments for cong_control of struct
> tcp_congestion_ops:
>  - ack
>  - flag
> These two arguments are inherited from the caller tcp_cong_control in
> tcp_intput.c. One use case of them is to update cwnd and pacing rate
> inside cong_control based on the info they provide. For example, the
> flag can be used to decide if it is the right time to raise or reduce a
> sender's cwnd.
>
> Another change in this patch is to allow the write of tp->snd_cwnd_stamp
> for a bpf tcp ca program. An use case of writing this field is to keep
> track of the time whenever tp->snd_cwnd is raised or reduced inside the
> cong_control callback.
>
> Signed-off-by: Miao Xu <miaxu@...a.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>