netdev - Re: [PATCH 1/3] net: bcmgenet: synchronize EXT_RGMII_OOB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240427141617.GK516117@kernel.org>
Date: Sat, 27 Apr 2024 15:16:17 +0100
From: Simon Horman <horms@...nel.org>
To: Doug Berger <opendmb@...il.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access

On Thu, Apr 25, 2024 at 03:10:05PM -0700, Doug Berger wrote:
> The EXT_RGMII_OOB_CTRL register can be written from different
> contexts. It is predominantly written from the adjust_link
> handler which is synchronized by the phydev->lock, but can
> also be written from a different context when configuring the
> mii in bcmgenet_mii_config().
> 
> The chances of contention are quite low, but it is conceivable
> that adjust_link could occur during resume when WoL is enabled
> so use the phydev->lock synchronizer in bcmgenet_mii_config()
> to be sure.
> 
> Fixes: afe3f907d20f ("net: bcmgenet: power on MII block for all MII modes")
> Cc: stable@...r.kernel.org
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>