netdev - Re: [PATCH 3/3] net: bcmgenet: synchronize UMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240427141638.GM516117@kernel.org>
Date: Sat, 27 Apr 2024 15:16:38 +0100
From: Simon Horman <horms@...nel.org>
To: Doug Berger <opendmb@...il.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 3/3] net: bcmgenet: synchronize UMAC_CMD access

On Thu, Apr 25, 2024 at 03:10:07PM -0700, Doug Berger wrote:
> The UMAC_CMD register is written from different execution
> contexts and has insufficient synchronization protections to
> prevent possible corruption. Of particular concern are the
> acceses from the phy_device delayed work context used by the
> adjust_link call and the BH context that may be used by the
> ndo_set_rx_mode call.
> 
> A spinlock is added to the driver to protect contended register
> accesses (i.e. reg_lock) and it is used to synchronize accesses
> to UMAC_CMD.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Cc: stable@...r.kernel.org
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>