[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240427173725.GB2323996@kernel.org>
Date: Sat, 27 Apr 2024 18:37:25 +0100
From: Simon Horman <horms@...nel.org>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Ariel Elior <aelior@...vell.com>,
Manish Chopra <manishc@...vell.com>, Jiri Pirko <jiri@...nulli.us>,
Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net 2/4] net: qede: use return from
qede_parse_flow_attr() for flower
On Fri, Apr 26, 2024 at 09:12:24AM +0000, Asbjørn Sloth Tønnesen wrote:
> In qede_add_tc_flower_fltr(), when calling
> qede_parse_flow_attr() then the return code
> was only used for a non-zero check, and then
> -EINVAL was returned.
>
> qede_parse_flow_attr() can currently fail with:
> * -EINVAL
> * -EOPNOTSUPP
> * -EPROTONOSUPPORT
>
> This patch changes the code to use the actual
> return code, not just return -EINVAL.
>
> The blaimed commit introduced these functions.
>
> Only compile tested.
>
> Fixes: 2ce9c93eaca6 ("qede: Ingress tc flower offload (drop action) support.")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists