Message-ID: <f5eb359a-fdbf-4b0a-8df5-be034da1aca3@arinc9.com>
Date: Mon, 29 Apr 2024 16:17:40 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
 Sean Wang <sean.wang@...iatek.com>, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Bartel Eerdekens <bartel.eerdekens@...stell8.be>, mithat.guner@...ont.com,
 erkin.bozoglu@...ont.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: detect PHY muxing when PHY is
 defined on switch MDIO bus

On 29.04.2024 12:58, Russell King (Oracle) wrote:
> On Mon, Apr 29, 2024 at 12:46:43PM +0300, Arınç ÜNAL via B4 Relay wrote:
>> From: Arınç ÜNAL <arinc.unal@...nc9.com>
>>
>> Currently, the MT7530 DSA subdriver configures the MT7530 switch to provide
>> direct access to switch PHYs, meaning, the switch PHYs listen on the MDIO
>> bus the switch listens on. The PHY muxing feature makes use of this.
>>
>> This is problematic as the PHY may be probed before the switch is
>> initialised, in which case attaching the PHY will fail.
>>
>> Since commit 91374ba537bd ("net: dsa: mt7530: support OF-based registration
>> of switch MDIO bus"), we can describe the switch PHYs on the MDIO bus of
>> the switch on the device tree. Extend the check to detect PHY muxing when
>> the PHY is defined on the MDIO bus of the switch on the device tree.
>>
>> When the PHY is described this way, the switch will be initialised first,
>> then the switch MDIO bus will be registered. Only after these steps, the
>> PHY will be probed.
> 
> Looking at the commit description and the patch, I'm not sure whether
> you really mean "probed" or whether you mean "attached".
> 
> PHY drivers will bind to PHY devices when they are detected on the MDIO
> bus (either by scanning or instantiating firmware description) and the
> devices are registered. As each device is registered, the drivers for
> the bus type are scanned and any matches will have their probe function
> called. This happens outside of any control of the DSA driver if the
> DSA device is on the same MDIO bus.
> 
> This is separate from the process of looking up a PHY and attaching the
> PHY.
> 
> So, I think there is probably a terminology issue with the patch
> description. I suspect you don't mean "probing" as in phy_probe() being
> called. Looking at the code, it looks like the driver is making
> decisions based on how PHYs are connected to the ethernet MACs in the
> device tree, and you're making decisions based on that. I wouldn't call
> that "probing" a PHY.

Yes, I meant to say "looking up a PHY and attaching the PHY" by probing a
PHY. I'll adjust the patch log to below, thanks.

Currently, the MT7530 DSA subdriver configures the MT7530 switch to provide
direct access to switch PHYs, meaning, the switch PHYs listen on the MDIO
bus the switch listens on. The PHY muxing feature makes use of this.

This is problematic as the PHY may be attached before the switch is
initialised, in which case, the PHY will fail to be attached.

Since commit 91374ba537bd ("net: dsa: mt7530: support OF-based registration
of switch MDIO bus"), we can describe the switch PHYs on the MDIO bus of
the switch on the device tree. Extend the check to detect PHY muxing when
the PHY is defined on the MDIO bus of the switch on the device tree.

When the PHY is described this way, the switch will be initialised first,
then the switch MDIO bus will be registered. Only after these steps, the
PHY will be attached.

Arınç

Powered by blists - more mailing lists