netdev - Re: [PATCH net-next] net: loopback: Do not allocate tstats explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zi-k2cAjbSMdIDjs@hog>
Date: Mon, 29 Apr 2024 15:47:05 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	leit@...a.com,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: loopback: Do not allocate tstats explicitly

(nit on the subject: you mention "tstats", but the code actually uses
lstats. I guess that's not worth a v2)

2024-04-29, 01:55:58 -0700, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the loopback driver and leverage the network
> core allocation instead.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina