netdev - Re: [PATCH net-next] net: sfp-bus: constify link_modes to sfp_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zi9hRst2uBGgbWo9@shell.armlinux.org.uk>
Date: Mon, 29 Apr 2024 09:58:46 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: sfp-bus: constify link_modes to
 sfp_select_interface()

On Mon, Apr 29, 2024 at 08:25:11AM +0000, Daniel Machon wrote:
> > @@ -593,7 +593,7 @@ static inline void sfp_parse_support(struct sfp_bus *bus,
> >  }
> > 
> >  static inline phy_interface_t sfp_select_interface(struct sfp_bus *bus,
> > -                                                  unsigned long *link_modes)
> > +                                               const unsigned long *link_modes)
> 
> There seem to be some misalignment on the opening brace - at least in my
> editor..

It's intentional to avoid going over column 80 (I use an 80 column wide
terminal to edit.) It's either that or the thing gets wrapped differently
(which then means one loses the return code when grepping.) From a
readability point of view, this is what I prefer.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!