netdev - Re: [PATCH ipsec-next v14 0/4] xfrm: Introduce direction attribute for SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjC68onD2DvsX6Qy@hog>
Date: Tue, 30 Apr 2024 11:33:38 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Antony Antony <antony.antony@...unet.com>
Cc: Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	devel@...ux-ipsec.org, Leon Romanovsky <leon@...nel.org>,
	Eyal Birger <eyal.birger@...il.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH ipsec-next v14 0/4] xfrm: Introduce direction attribute
 for SA

2024-04-30, 09:08:06 +0200, Antony Antony wrote:
> Hi,
> 
> Inspired by the upcoming IP-TFS patch set, and confusions experienced in
> the past due to lack of direction attribute on SAs, add a new direction
> "dir" attribute. It aims to streamline the SA configuration process and
> enhance the clarity of existing SA attributes.
> 
> This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
> ('in' for input or 'out' for output). Alsp add validations of existing
> direction-specific SA attributes during configuration and in the data
> path lookup.
> 
> This change would not affect any existing use case or way of configuring
> SA. You will notice improvements when the new 'dir' attribute is set.
> 
> v14: add more SA flag checks.
> v13: has one fix, minor documenation updates, and function renaming.
> 
> Antony Antony (4):
>   xfrm: Add Direction to the SA in or out
>   xfrm: Add dir validation to "out" data path lookup
>   xfrm: Add dir validation to "in" data path lookup
>   xfrm: Restrict SA direction attribute to specific netlink message
>     types

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Antony.

Patches 2 and 3 are identical to v13 so you could have kept Nicolas's
Reviewed-by tags. Steffen, I guess you can copy them in case Nicolas
doesn't look at v14 by the time you apply it?

-- 
Sabrina