netdev - Re: [PATCH net-next v3 1/6] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Apr 2024 17:40:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, jiri@...nulli.us, horms@...nel.org
Subject: Re: [PATCH net-next v3 1/6] net: tn40xx: add pci driver for Tehuti
 Networks TN40xx chips

> diff --git a/drivers/net/ethernet/tehuti/tn40.c b/drivers/net/ethernet/tehuti/tn40.c
> new file mode 100644
> index 000000000000..fe2c392abe31
> --- /dev/null
> +++ b/drivers/net/ethernet/tehuti/tn40.c
> @@ -0,0 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright (c) Tehuti Networks Ltd. */
> +
> +#include "tn40.h"

> +++ b/drivers/net/ethernet/tehuti/tn40.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (c) Tehuti Networks Ltd. */
> +
> +#ifndef _TN40_H_
> +#define _TN40_H_
> +
> +#include <linux/module.h>
> +#include <linux/pci.h>

It is not the kernel style to hide standard headers within a header
file. These includes should be in tn40.c.

      Andrew