netdev - Re: [PATCH net] e1000e: change usleep_range to udelay in PHY mdic access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240430173131.GA2575892@kernel.org>
Date: Tue, 30 Apr 2024 18:31:31 +0100
From: Simon Horman <horms@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Vitaly Lifshits <vitaly.lifshits@...el.com>,
	regressions@...mhuis.info, stable@...r.kernel.org,
	Jérôme Carretero <cJ@...gloub.eu>,
	Sasha Neftin <sasha.neftin@...el.com>,
	Dima Ruinskiy <dima.ruinskiy@...el.com>
Subject: Re: [PATCH net] e1000e: change usleep_range to udelay in PHY mdic
 access

On Mon, Apr 29, 2024 at 10:10:40AM -0700, Tony Nguyen wrote:
> From: Vitaly Lifshits <vitaly.lifshits@...el.com>
> 
> This is a partial revert of commit 6dbdd4de0362 ("e1000e: Workaround
> for sporadic MDI error on Meteor Lake systems"). The referenced commit
> used usleep_range inside the PHY access routines, which are sometimes
> called from an atomic context. This can lead to a kernel panic in some
> scenarios, such as cable disconnection and reconnection on vPro systems.
> 
> Solve this by changing the usleep_range calls back to udelay.
> 
> Fixes: 6dbdd4de0362 ("e1000e: Workaround for sporadic MDI error on Meteor Lake systems")
> Cc: stable@...r.kernel.org
> Reported-by: Jérôme Carretero <cJ@...gloub.eu>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218740
> Closes: https://lore.kernel.org/lkml/a7eb665c74b5efb5140e6979759ed243072cb24a.camel@zougloub.eu/
> Co-developed-by: Sasha Neftin <sasha.neftin@...el.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@...el.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> Tested-by: Dima Ruinskiy <dima.ruinskiy@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>