[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240501200917.GL516117@kernel.org>
Date: Wed, 1 May 2024 21:09:17 +0100
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, netfilter-devel@...r.kernel.org,
pablo@...filter.org
Subject: Re: [PATCH net-next] selftests: netfilter: nft_concat_range.sh:
reduce debug kernel run time
On Wed, May 01, 2024 at 09:41:53PM +0200, Florian Westphal wrote:
> Simon Horman <horms@...nel.org> wrote:
> > On Tue, Apr 30, 2024 at 04:58:07PM +0200, Florian Westphal wrote:
> >
> > ...
> >
> > > diff --git a/tools/testing/selftests/net/netfilter/nft_concat_range.sh b/tools/testing/selftests/net/netfilter/nft_concat_range.sh
> >
> > ...
> >
> > > @@ -1584,10 +1594,16 @@ for name in ${TESTS}; do
> > > continue
> > > fi
> > >
> > > - printf " %-60s " "${display}"
> > > + [ "$KSFT_MACHINE_SLOW" = "yes" ] && count=1
> > > +
> > > + printf " %-32s " "${display}"
> > > + tthen=$(date +%s)
> > > eval test_"${name}"
> > > ret=$?
> > >
> > > + tnow=$(date +%s)
> > > + printf "%5ds%-30s" $((tnow-tthen))
> > > +
> >
> > Hi Florian,
> >
> > A minor nit: the format string above expects two variables, but only one
> > is passed.
>
> Its intentional, I thought this was better than "%5ds "
> or similar.
Understood, thanks.
Powered by blists - more mailing lists