netdev - Re: [PATCH net-next 03/10] gve: Add adminq funcs to add/remove a single Rx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240501041930.GA72628@maili.marvell.com>
Date: Wed, 1 May 2024 09:49:30 +0530
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Shailend Chand <shailend@...gle.com>
CC: <netdev@...r.kernel.org>, <almasrymina@...gle.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <hramamurthy@...gle.com>, <jeroendb@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <pkaligineedi@...gle.com>,
        <willemb@...gle.com>
Subject: Re: [PATCH net-next 03/10] gve: Add adminq funcs to add/remove a
 single Rx queue

On 2024-05-01 at 04:44:12, Shailend Chand (shailend@...gle.com) wrote:
> +int gve_adminq_destroy_single_rx_queue(struct gve_priv *priv, u32 queue_index)
> +{
> +	union gve_adminq_command cmd;
> +	int err;
> +
> +	gve_adminq_make_destroy_rx_queue_cmd(&cmd, queue_index);
> +	err = gve_adminq_execute_cmd(priv, &cmd);
> +	if (err)
why can't you return err directly ? no need of if statement.
> +		return err;

> +
> +	return 0;
>