netdev - Re: [PATCH net-next v2 1/3] Add new args for cong_control in tcp_congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240501062653.09abec31@kernel.org>
Date: Wed, 1 May 2024 06:26:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Miao Xu <miaxu@...a.com>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...nel.org>, Martin Lau <kafai@...a.com>,
 <netdev@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] Add new args for cong_control in
 tcp_congestion_ops

On Wed, 1 May 2024 00:43:36 -0700 Miao Xu wrote:
> This patch adds two new arguments for cong_control of struct
> tcp_congestion_ops:
>  - ack
>  - flag
> These two arguments are inherited from the caller tcp_cong_control in
> tcp_intput.c. One use case of them is to update cwnd and pacing rate
> inside cong_control based on the info they provide. For example, the
> flag can be used to decide if it is the right time to raise or reduce a
> sender's cwnd.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> --

three dashes here ---

> Changes in v2:
> * Split the v1 patch into 2 separate patches. In particular, spin out
> bpf_tcp_ca.c as a separate patch because it is bpf specific.
> 
> Signed-off-by: Miao Xu <miaxu@...a.com>

This goes after Eric's review tag.

Looks like you need to adjust one of the BPF selftests:

Error: #29/14 bpf_tcp_ca/tcp_ca_kfunc
  Error: #29/14 bpf_tcp_ca/tcp_ca_kfunc
  libbpf: extern (func ksym) 'bbr_main': func_proto [213] incompatible with vmlinux [48152]
  libbpf: failed to load object 'tcp_ca_kfunc'
  libbpf: failed to load BPF skeleton 'tcp_ca_kfunc': -22
  test_tcp_ca_kfunc:FAIL:tcp_ca_kfunc__open_and_load unexpected error: -22