netdev - Re: [PATCH net] ax25: Fix refcount leak issues of ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0503e3ff778955d2e2b94e746193a5ed73cf61b.camel@redhat.com>
Date: Thu, 02 May 2024 11:30:32 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, duoming@....edu.cn
Cc: linux-hams@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kuba@...nel.org, edumazet@...gle.com, 
	davem@...emloft.net, jreuter@...na.de, lars@...bit.com, Miroslav Skoric
	 <skoric@....ac.rs>
Subject: Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev

On Thu, 2024-05-02 at 10:56 +0300, Dan Carpenter wrote:
> On Thu, May 02, 2024 at 12:35:44PM +0800, duoming@....edu.cn wrote:
> > On Wed, 1 May 2024 20:43:37 +0300 Dan Carpenter wrote:
> > > I'm always happy to take credit for stuff but the Reported by should go
> > > to Lars and Miroslav.
> > > 
> > > Reported-by: Lars Kellogg-Stedman <lars@...bit.com>
> > > Reported-by: Miroslav Skoric <skoric@....ac.rs>
> > 
> > This patch is not related with the problem raised by Lars Kellogg-Stedman
> > and Miroslav Skoric, it only solves the reference counting leak issues of
> > ax25_dev in ax25_addr_ax25dev() and ax25_dev_device_down(). So I think
> > there is no need to change the "Reported by" label.
> > 
> 
> Ah...  I was really hoping it was related to the other bugs.
> 
> Okay, what about we separate this into different patches one for each
> bug?  The changes to ax25_addr_ax25dev() and ax25_dev_free() are
> obvious and could go in as-is but as two separate patches.

I agree it would be better to split this up, the changelog itself hints
at 2 separated issues and fixes.

Thanks,

Paolo