netdev - Re: [PATCH net-next] selftests: net: py: check process exit code in bkg() and background cmd()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6633a18916f75_3971a0294c1@willemb.c.googlers.com.notmuch>
Date: Thu, 02 May 2024 10:22:01 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 Jakub Kicinski <kuba@...nel.org>, 
 Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] selftests: net: py: check process exit code in
 bkg() and background cmd()

Jakub Kicinski wrote:
> We're a bit too loose with error checking for background
> processes. cmd() completely ignores the fail argument
> passed to the constructor if background is True.
> Default to checking for errors if process is not terminated
> explicitly. Caller can override with True / False.
> 
> For bkg() the processing step is called magically by __exit__
> so record the value passed in the constructor.
> 
> Reported-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Tested-by: Willem de Bruijn <willemb@...gle.com>

Thanks!