netdev - Re: [PATCH net-next v2 00/10] gve: Implement queue api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6633ae24535a9_39851d29434@willemb.c.googlers.com.notmuch>
Date: Thu, 02 May 2024 11:15:48 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Shailend Chand <shailend@...gle.com>, 
 netdev@...r.kernel.org
Cc: almasrymina@...gle.com, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 hramamurthy@...gle.com, 
 jeroendb@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 pkaligineedi@...gle.com, 
 rushilg@...gle.com, 
 willemb@...gle.com, 
 ziweixiao@...gle.com, 
 Shailend Chand <shailend@...gle.com>
Subject: Re: [PATCH net-next v2 00/10] gve: Implement queue api

Shailend Chand wrote:
> Following the discussion on
> https://patchwork.kernel.org/project/linux-media/patch/20240305020153.2787423-2-almasrymina@google.com/,
> the queue api defined by Mina is implemented for gve.
> 
> The first patch is just Mina's introduction of the api. The rest of the
> patches make surgical changes in gve to enable it to work correctly with
> only a subset of queues present (thus far it had assumed that either all
> queues are up or all are down). The final patch has the api
> implementation.
> 
> Changes since v1: clang warning fixes, kdoc warning fix, and addressed
> review comments.
> 
> Mina Almasry (1):
>   queue_api: define queue api
> 
> Shailend Chand (9):
>   gve: Make the GQ RX free queue funcs idempotent
>   gve: Add adminq funcs to add/remove a single Rx queue
>   gve: Make gve_turn(up|down) ignore stopped queues
>   gve: Make gve_turnup work for nonempty queues
>   gve: Avoid rescheduling napi if on wrong cpu
>   gve: Reset Rx ring state in the ring-stop funcs
>   gve: Account for stopped queues when reading NIC stats
>   gve: Alloc and free QPLs with the rings
>   gve: Implement queue api

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

That QPLS alloc reorg is a great simplification. Nice bonus.